Do not configure the root logger. #741
Conversation
|
The root logger is implicitly configured by functions like logging.warning; you shouldn't rely on the root logger remaining unconfigured. Instead, if you attach a handler to a logger that would be redundant with a root handler, set the propagate attribute of that logger to false: http://docs.python.org/2/library/logging.html#logging.Logger.propagate |
|
Ah, thanks for that :) However, I would still discourage usage of logging.basicConfig because it could be called from within a thread and you shouldn't do that... |
|
Yes, but given the existence of logging.warning and friends, all multithreaded apps should explicitly configure their loggers before starting any threads unless they're sure that these functions are never used. |
|
Agreed. Thanks again for the |
Calling
basicConfigleaks to other custom defined loggers, so this leads to undesirable behavior. For example in this code example log messages gets printed out twice:This PR changes the check of handlers by adding only the basicConfig handlers to the Tornado loggers.